Update generator.ts to allow %23 (#) in dynamic urls

.changeset/mean-geckos-sell.md

@@ -0,0 +1,5 @@
+---
+"astro": minor
+---
+
+Update generator.ts to allow %23 (#) in dynamic urls

packages/astro/src/core/routing/manifest/generator.ts

@@ -2,6 +2,20 @@ import type { AstroConfig, RoutePart } from '../../../@types/astro.js';
 
 import { compile } from 'path-to-regexp';
 
+function sanitizeParams(params: Record<string, string | number | undefined>): Record<string, string | number | undefined> {
+	return Object.entries(params).reduce((acc, [key, value]) => {
+		if (typeof value === 'string') {
+			acc[key] = value
+				.normalize()
+				.replace(/#/g, '%23')
+				.replace(/\?/g, '%3F')
+		} else {
+			acc[key] = value;
+		}
+		return acc;
+	}, {} as Record<string, string | number | undefined>);
+}
+
 export function getRouteGenerator(
 	segments: RoutePart[][],
 	addTrailingSlash: AstroConfig['trailingSlash']
@@ -37,8 +51,9 @@ export function getRouteGenerator(
 		trailing = '/';
 	}
 	const toPath = compile(template + trailing);
-	return (params: object): string => {
-		const path = toPath(params);
+	return (params: Record<string, string | number | undefined>): string => {
+		const sanitizedParams = sanitizeParams(params);
+		const path = toPath(sanitizedParams);
 
 		// When generating an index from a rest parameter route, `path-to-regexp` will return an
 		// empty string instead "/". This causes an inconsistency with static indexes that may result

packages/astro/test/ssr-params.test.js

@@ -42,11 +42,11 @@ describe('Astro.params in SSR', () => {
 
 	it('No double URL decoding', async () => {
 		const app = await fixture.loadTestAdapterApp();
-		const request = new Request('http://example.com/users/houston/%25');
+		const request = new Request('http://example.com/users/houston/%25%23%3F');
 		const response = await app.render(request);
 		assert.equal(response.status, 200);
 		const html = await response.text();
 		const $ = cheerio.load(html);
-		assert.equal($('.category').text(), '%');
+		assert.equal($('.category').text(), '%#?');
 	});
 });