Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run cherry-pick workflow on PRs targeting trunk. #38896

Closed
jonathansadowski opened this issue Jun 22, 2023 · 1 comment · Fixed by nigeljamesstevenson/woocommerce#7 or #47312
Closed

Only run cherry-pick workflow on PRs targeting trunk. #38896

jonathansadowski opened this issue Jun 22, 2023 · 1 comment · Fixed by nigeljamesstevenson/woocommerce#7 or #47312
Assignees
@nigeljamesstevenson
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: release Issues related to releasing WooCommerce. team: Solaris type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@jonathansadowski
Copy link
Contributor

Description

The cherry-pick workflow runs whenever a milestone is added to a PR or if a PR that already had a milestone is merged, whenever the selected milestone isn't the ongoing release. This happens regardless of the base branch, which can cause issues when a PR is merged that targets another branch, such as happened with p1687463971495799-slack-C01DT6U03HC.

Acceptance criteria

  • If a PR is merged with a milestone (or a milestone is added to a PR after it's merged) that targets a branch other than trunk, we shouldn't run the cherry-pick workflow.
@jonathansadowski jonathansadowski added type: task The issue is an internally driven task (e.g. from another A8c team). status: prioritization focus: monorepo infrastructure Issues and PRs related to monorepo tooling. labels Jun 22, 2023
@jonathansadowski jonathansadowski self-assigned this Oct 23, 2023
@juliaamosova juliaamosova added the focus: release Issues related to releasing WooCommerce. label Mar 29, 2024
@nigeljamesstevenson
Copy link
Contributor

https://github.com/woocommerce/woocommerce/pull/39867/files might be useful as a reference

@nigeljamesstevenson nigeljamesstevenson mentioned this issue May 2, 2024
Merged
11 tasks
@nigeljamesstevenson nigeljamesstevenson mentioned this issue May 9, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigeljamesstevenson nigeljamesstevenson

Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: release Issues related to releasing WooCommerce. team: Solaris type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
WooCommerce Core Maintenance
Status: Done
Milestone
No milestone
4 participants
@rrennick @jonathansadowski @juliaamosova @nigeljamesstevenson