New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the cherry pick operation only executes against trunk
#47312
Ensure the cherry pick operation only executes against trunk
#47312
Conversation
…tch-3 Update README.md
Hi @rodelgc, @Stojdza, @alvarothomas, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0cd8740
into
woocommerce:trunk
Submission Review Guidelines:
Changes proposed in this Pull Request:
If a PR is merged with a milestone (or a milestone is added to a PR after it's merged) that targets a branch other than trunk, we shouldn't run the cherry-pick workflow.
Closes #38896
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Disable unnecessary workflows in your Fork to save bandwidth (you only need this workflow to be operational)
Create some milestones for testing purposes e.g.
9.1.0
,9.0.0
,8.9.0
,8.8.0
Create and merge a PR in your Fork targeting trunk for testing purposes. If you have one already, you can use it.
This PR will likely be assigned a valid Milestone e.g. 9.0.0 if the appropriate workflow is enabled on your fork.
Attempt to 'cherry pick' the PR created in step 6 into a release branch by assigning it another milestone e.g. 8.9.0
Validate that the cherry pick operation kicks off and attempts to perform the appropriate cherry-picking by progressing to the Prep inputs task
Create and merge a PR in your Fork targeting a release branch (such as release/8.9) for testing purposes. If you have one already, you can use it.
Attempt to 'cherry pick' this PR into a release branch by assigning it another milestone e.g.
8.9.0
Validate that the cherry pick operation does not kick off and does not attempt to perform the appropriate cherry-picking and does not progress to the Prep inputs task
Changelog entry
Significance
Type
Message
Comment