Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make german state field visible but not required #47319

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

senadir
Copy link
Member

@senadir senadir commented May 9, 2024

Germany state field was always set to hidden and optional, at some point later, states were added to it #31825, but the field was never marked as visible.

Shortcode checkout will always show the state fields if there are states, but checkout block won't, and would respect whatever is in locale settings. That's a separate debate for now #47317.

This PR only marks the state as visible, following other patterns done for other countries.

How to test the changes in this Pull Request:

  1. In Checkout block, select Germany, make sure you can see german states list.
  2. In Checkout shortcode, select Germany, make sure you can see german states list.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Show Germany state field in Checkout block.

Comment

@senadir senadir added type: bug The issue is a confirmed bug. focus: checkout Issues related to checkout page. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels May 9, 2024
@senadir senadir self-assigned this May 9, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 9, 2024
@woocommercebot woocommercebot requested review from a team and opr and removed request for a team May 9, 2024 12:50
Copy link
Contributor

github-actions bot commented May 9, 2024

Hi @opr,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 9, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@opr
Copy link
Contributor

opr commented May 9, 2024

Not sure why the CI hasn't added the changelog, maybe this needs to be closed and reopened to trigger?

@senadir senadir closed this May 10, 2024
@senadir senadir reopened this May 10, 2024
@github-actions github-actions bot added focus: api tests Issues related to API tests. focus: e2e tests Issues related to e2e tests plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. tool: monorepo infrastructure labels May 10, 2024
@github-actions github-actions bot removed tool: monorepo infrastructure focus: e2e tests Issues related to e2e tests plugin: woocommerce beta tester Issues related to the WooCommerce Beta Tester plugin. focus: api tests Issues related to API tests. labels May 10, 2024
@senadir senadir enabled auto-merge (squash) May 13, 2024 15:15
@senadir senadir merged commit de4180c into trunk May 13, 2024
25 checks passed
@senadir senadir deleted the fix/show-germany-state branch May 13, 2024 15:19
@github-actions github-actions bot added this to the 9.0.0 milestone May 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 13, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout Issues related to checkout page. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants