New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make german state field visible but not required #47319
Conversation
Hi @opr, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Not sure why the CI hasn't added the changelog, maybe this needs to be closed and reopened to trigger? |
9085c31
to
7425225
Compare
7425225
to
c288196
Compare
Germany state field was always set to hidden and optional, at some point later, states were added to it #31825, but the field was never marked as visible.
Shortcode checkout will always show the state fields if there are states, but checkout block won't, and would respect whatever is in locale settings. That's a separate debate for now #47317.
This PR only marks the state as visible, following other patterns done for other countries.
How to test the changes in this Pull Request:
Changelog entry
Significance
Type
Message
Show Germany state field in Checkout block.
Comment