Prevent Additional Checkout Fields values being shown on shortcode order confirmation

[opr]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When using the shortcode checkout, no fields added by the Additional Checkout Fields API are shown, which is the intended behaviour, but because we show "No" for unchecked checkboxes on the order confirmation screen, it appeared like the user had intentionally selected that during checkout despite the field not being present on the front end.

This PR checks the source of the order before determining what fields to show. If it was not made via the Store API then no fields will be shown.

Closes #47265 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Install the https://github.com/woocommerce/additional-checkout-fields-tester plugin ((https://github.com/woocommerce/woocommerce/files/15265418/additional-checkout-fields-tester-main.5.zip))
2. Add an item to your cart and go to the Checkout block - ensure the additional fields show up (as per the readme of the above repository).
3. Fill in the form, ensuring all fields are filled, and check out.
4. Ensure the order confirmation contains the values of the additional field.
5. Check the email sent to the shopper and the merchant and ensure both have the fields.
6. Check the order in the WooCommerce dashboard, ensure the fields are there.
7. Add an item to your cart and check out using the shortcode checkout experience.
8. Ensure the fields don't show, then check out.
9. Ensure the order confirmation contains the values of the additional field.
10. Check the email sent to the shopper and the merchant and ensure neither show any of the fields.
11. Check the order in the WooCommerce dashboard, ensure the fields are not there.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Hi @alexflorisca,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[alexflorisca]

Nice work, it all tests out ok