Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LYS - Use flow layout for the coming soon template #47335

Merged
merged 5 commits into from May 13, 2024

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented May 9, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #47193 .

This PR updates the coming soon template to use flow layout to fix the text layout issue.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new JN site with this branch.
  2. Go to WooCommerce -> Settings -> Site Visibility and change the mode to Coming soon and enable Restrict to store pages only option.
  3. Click Save changes
  4. Open an Incognito session.
  5. Go to https://your-site/cart
  6. Confirm Great things are on the horizon is displayed in one line.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

LYS - Use flow layout for the coming soon template

Comment

@moon0326 moon0326 requested review from a team, psealock and rjchow May 9, 2024 17:41
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@moon0326 moon0326 closed this May 10, 2024
@moon0326 moon0326 reopened this May 10, 2024
Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well on frontend but it seems that block can't be previewed in the editor. I guess we need to make more changes somewhere else. 🤔

Screenshot 2024-05-10 at 10 20 50

@moon0326
Copy link
Contributor Author

Use flex layout

Good catch! It should have been flex. Updated it in Use flex layout

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm able to see the editor working now.

Tests well, LGTM! 🚢

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adrianduffell
Copy link
Contributor

Nice work @moon0326! Merging this on your behalf

@adrianduffell adrianduffell merged commit 6cf09f3 into trunk May 13, 2024
43 checks passed
@adrianduffell adrianduffell deleted the update/47193-fix-windowed-text-in-tt4 branch May 13, 2024 05:15
@github-actions github-actions bot added this to the 9.0.0 milestone May 13, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 13, 2024
@rodelgc rodelgc added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Launch Your Store] Widowed text in TT4 coming soon template for store pages
6 participants