Request attributes conditionally

[octaedro]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR adds the changes to request the available attributes conditionally when they will be used under the Variations tab.

Before

After

Closes #47357.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Make sure the New product is enabled under /wp-admin/admin.php?page=wc-settings&tab=advanced&section=features.
2. Checkout this branch and build the project.
3. Open the browser's devTools and go to the Network tab.
4. Edit a variable product
5. Refresh the page and verify that we don't request the available attributes (terms?attribute_id=) when the component is not visible.
6. Go to the Variations tab and verify the request was made.
7. Go to the Organization tab and Add a new attribute. Remember that the REST API request is only made under the Variations tab.
8. The new attribute should be visible in the Attributes section.
9. Save the product.
10. Verify everything looks correct after reloading the product.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Hi @mdperez86,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[mdperez86]

Hey @octaedro nice job here. I left one comment.

[octaedro]

Thank you @mdperez86, for reviewing this. I just added your suggestion.
Could you take another look at this PR?

[mdperez86]

I left one comment on this @octaedro I think we need to prevent the other /terms request from the Organization tab

[mdperez86]

Since the AttributeContainer no longer has any logic and is not reused elsewhere apart form the attributes block. I think is better to remove it.

[mdperez86]

LGTM @octaedro nice job!!