Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkout sidebar (order summary) sticky on desktop #47376

Merged
merged 4 commits into from May 17, 2024

Conversation

senadir
Copy link
Member

@senadir senadir commented May 10, 2024

This PR turns the order summary to sticky on desktop, but keeps as is for now on mobile, because we're going to switch up how it's rendered.

Closes #42230

Screen.Recording.2024-05-10.at.8.30.42.PM.mov

How to test the changes in this Pull Request:

  1. Test scrolling on different browsers, make sure the whole sidebar is visible.
  2. Ensure the cart sidebar is also sticky.
  3. Ensure that on mobile, it's not sticky.

Ensure that warning in the sidebar are also sticky:

  1. Enable Local Pickup.
  2. Disable shipping via WooCommerce -> Settings -> General section or by disable all existing rates.
  3. On Checkout, go to shipping, make sure the warning is visible and sticky.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Mark the checkout block sidebar as sticky on desktop.

Comment

@senadir senadir added type: enhancement The issue is a request for an enhancement. focus: checkout Issues related to checkout page. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels May 10, 2024
@senadir senadir self-assigned this May 10, 2024
@woocommercebot woocommercebot requested review from a team and opr and removed request for a team May 10, 2024 18:32
Copy link
Contributor

Hi @opr,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 10, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@senadir senadir closed this May 13, 2024
@senadir senadir reopened this May 13, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 13, 2024
Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great in Edge, Firefox, and Safari.

Noting that this also makes the cart sidebar sticky, is this intentional? With many shipping methods, or many packages in the cart, the proceed to checkout button is hidden from view until the user scrolls all the way down, I feel like this isn't the best behaviour, could we confirm that this is intentional?

I also have some feedback on the testing instructions, for the Ensure that warning in the sidebar are also sticky: section, I think it'd be nice if you mention that shipping is disabled in the WooCommerce -> Settings -> General section. (Just to help testers out a bit with finding that option).

Thanks Nadir!

@nikkivias
Copy link

Agree with Thomas that we only apply this to the Checkout summary

@senadir senadir requested a review from opr May 16, 2024 14:47
@senadir
Copy link
Member Author

senadir commented May 17, 2024

FWI @opr this wasn't approved.

Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for me on Edge, Firefox, and Safari. 🚢 it!

@senadir senadir merged commit 1ae7ca5 into trunk May 17, 2024
38 checks passed
@senadir senadir deleted the add/sticky-order-summary branch May 17, 2024 11:13
@github-actions github-actions bot added this to the 9.0.0 milestone May 17, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 17, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout Issues related to checkout page. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sticky the order summary/cart summary when scrolling
4 participants