New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make checkout sidebar (order summary) sticky on desktop #47376
Conversation
Hi @opr, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great in Edge, Firefox, and Safari.
Noting that this also makes the cart sidebar sticky, is this intentional? With many shipping methods, or many packages in the cart, the proceed to checkout button is hidden from view until the user scrolls all the way down, I feel like this isn't the best behaviour, could we confirm that this is intentional?
I also have some feedback on the testing instructions, for the Ensure that warning in the sidebar are also sticky:
section, I think it'd be nice if you mention that shipping is disabled in the WooCommerce -> Settings -> General section. (Just to help testers out a bit with finding that option).
Thanks Nadir!
Agree with Thomas that we only apply this to the Checkout summary |
7682101
to
0f6f275
Compare
FWI @opr this wasn't approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great for me on Edge, Firefox, and Safari. 🚢 it!
This PR turns the order summary to sticky on desktop, but keeps as is for now on mobile, because we're going to switch up how it's rendered.
Closes #42230
Screen.Recording.2024-05-10.at.8.30.42.PM.mov
How to test the changes in this Pull Request:
Ensure that warning in the sidebar are also sticky:
Changelog entry
Significance
Type
Message
Mark the checkout block sidebar as sticky on desktop.
Comment