Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Block Editor: autofocus attributes combobox component #47378

Conversation

retrofox
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR introduces the autoFocus property to the <AttributesComboboxControl />, which is used by the New Attributes modal to focus the instance when right after it shows up.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the new Product Block Editor
  2. Go to the Variations Tab
  3. Click on the Add options
  4. Confirm that it always focuses in the Attribute combobox instance
Screen.Recording.2024-05-11.at.09.28.38.mov

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@retrofox retrofox added focus: accessibility The issue/PR is related to accessibility. focus: new product ux revamped product management experience team: Mothra labels May 11, 2024
@retrofox retrofox requested a review from a team May 11, 2024 08:29
@retrofox retrofox self-assigned this May 11, 2024
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented May 11, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@retrofox
Copy link
Contributor Author

Let's hold on until WordPress/gutenberg#61705 change are available 🤞

@retrofox retrofox closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility The issue/PR is related to accessibility. focus: new product ux revamped product management experience team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant