Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merging response nodes #772

Conversation

devsergiy
Copy link
Member

@devsergiy devsergiy commented Apr 16, 2024

  • fix merging response nodes issue leading to "non-nullable field can't be null" errors
  • fix duplicated fetches on complex abstract types queries
  • add fetch input to trace for skipped fetches

@devsergiy devsergiy force-pushed the sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different branch 2 times, most recently from 922f897 to c9cd9c3 Compare May 26, 2024 06:01
@devsergiy devsergiy force-pushed the sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different branch from c9cd9c3 to 3c4e432 Compare May 26, 2024 06:02
@devsergiy devsergiy changed the title try fetch extraction fix: merging response nodes May 26, 2024
@devsergiy devsergiy marked this pull request as ready for review May 27, 2024 14:43
Copy link
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsergiy devsergiy merged commit 5e89693 into master May 27, 2024
8 checks passed
@devsergiy devsergiy deleted the sergiy/eng-4874-fix-merging-response-nodes-under-the-same-path-but-different branch May 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants