fix: update websocket handlers to eliminate goroutine leaks (#796) #797
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensneuse
approved these changes
May 13, 2024
|
Please fix CI. ;-) |
BenjaminYong
force-pushed
the
fix/websocket-goroutine-leaks
branch
from
af62b84
to
c6e9925
Compare
|
@BenjaminYong friendly ping 😄 |
|
Sorry guys, been struggling to reproduce, though I'm on darwin/arm64. Mine doesn't fail like the CI does, any tips? |
|
@jensneuse @devsergiy @StarpTech CI is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
Please see the suggested fixes to address the issue I raised: #796
After this change, the websocket handlers and their goroutines are closing as expected. As a result, my memory usage is much more lower and no longer leaking.
Thanks,
Benny