Re-enable mfc sample #23963
Open
Re-enable mfc sample #23963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the problem here is that it only builds with MSVS and only when MFC is available (which is not always the case any more). So we'd need to test that MSVS is being used (probably simple) and ideally also that MFC is available (e.g. by checking for one of its headers?), otherwise this will break the build for all MinGW users. |
|
it is possible with MSVC CMake Variable to check compiler is Visual Studio. MFC base header file is afxwin.h |
vadz
added
work needed
|
Checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to build and run the sample without issues.