Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dylib symlinks on Apple Silicon Macs #24524

Merged
merged 1 commit into from May 13, 2024

Conversation

speleo3
Copy link
Contributor

@speleo3 speleo3 commented May 9, 2024

Fixes #23143

@vadz
Copy link
Contributor

vadz commented May 9, 2024

Nice, thanks! I was looking at this too and thought we could achieve the same thing by replacing

libnames=\`cd lib ; ls -1 | grep '\.[[0-9]][[0-9]]*\.dylib\$'\`

with just something like

libnames=\`find lib -type -f -name '*.dylib'\`

because I have no idea why do we need the check for digits, but this works too.

@speleo3
Copy link
Contributor Author

speleo3 commented May 9, 2024

Your find lib -type -f solution looks more elegant 👍

Assuming that no library links to a symlink name (that would need to be changed with -change).

@speleo3
Copy link
Contributor Author

speleo3 commented May 9, 2024

Successful test build: https://anaconda.org/speleo3/wxwidgets/files

@speleo3
Copy link
Contributor Author

speleo3 commented May 9, 2024

This also worked for me:

libnames=\`find lib -type f -name '*.dylib' | xargs basename\`

@vadz
Copy link
Contributor

vadz commented May 10, 2024

Please let me know which one do you prefer and if it's the find one, could you please (force) push to this PR so that I could be sure that I apply exactly what you tested? TIA!

BTW, a slight simplification would be to use

libnames=\`find lib -type f -name '*.dylib' -exec basename {} \; \`

but I'm not quite sure about the quoting.

@speleo3
Copy link
Contributor Author

speleo3 commented May 10, 2024

I have a slight preference for the current solution. I like that it's very explicit about not running install_name_tool on symlinks.

So I think this is ready for merging.

@vadz
Copy link
Contributor

vadz commented May 13, 2024

Thanks again, pushing this to master and will also include it in the upcoming 3.2.5 (just in time!).

@vadz vadz merged commit fa2fb36 into wxWidgets:master May 13, 2024
38 checks passed
vadz pushed a commit that referenced this pull request May 13, 2024
@speleo3 speleo3 deleted the fix-osx-arm64-symlinks branch May 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation failing on Apple Silicon Macs
2 participants