New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced dump to trace #3098
base: development
Are you sure you want to change the base?
Introduced dump to trace #3098
Conversation
cebbd21
to
6d182cb
Compare
The trace dump index is working and tested on a 136MB huge trace. |
Would you like this to be merged into |
I think those new files are already formatted, no idea why appveyor doesn't like that. I'll pause development for a while, but I don't think this feature is completed. The aim of this pull request is to bring in dump and stack windows, not to merely accelerate memory reference search. Of course I support merging it if you think merging this would allow other people to use this feature and contribute to it. Possibly disable the debug feature of dumping the trace memory in log view when clicking on "information" menu, it should be available in the dump tab instead. |
42d600b
to
37e4416
Compare
8d6f503
to
6f551fc
Compare
Dump widget has been added to trace, now it looks almost like the CPU view. There are still tons of usability problems and random crashes. |
52a6d98
to
7a6c225
Compare
It looks like this is conflicting with the changes in #3192 a bit. I will try to properly refactor the |
The following files are causing the formatting checks error btw:
Might be CRLF vs LF? |
✅ Download x64dbg 1.0.1711 (commit ab2a69cd13 by @torusrxxx) |
1784f30
to
ce9168b
Compare
✅ Download x64dbg 1.0.1725 (commit 3d0e2654a9 by @torusrxxx) |
Maybe refactor |
✅ Download x64dbg 1.0.1726 (commit f02671aeb3 by @torusrxxx) |
✅ Download x64dbg 1.0.1765 (commit ca0b06d70a by @torusrxxx) |
✅ Download x64dbg 1.0.1766 (commit 517b1ec646 by @torusrxxx) |
✅ Download x64dbg 1.0.1778 (commit 1ea8ab91d9 by @torusrxxx) |
DisableTraceDump setting has been added, it shouldn't break things horribly now. |
✅ Download x64dbg 1.0.1779 (commit 46c7849fee by @torusrxxx) |
✅ Download x64dbg 1.0.1784 (commit ae0467f80a by @torusrxxx) |
Heya, hope you're doing well! Do you have a list of things left to do for this? It would be nice to eventually merge all the PRs, but I don't know how stable this is... |
I was busy as usual at the end of the year. I have finished using it back in October. I didn't test this since then. The stack window is missing. However it would require a bit of work which unfortunately could not be finished in 2023, and I think it's fine, you can already use the dump like a stack window. Then it would be in maintenance mode. |
✅ Download x64dbg 1.0.1855 (commit a609f1e98e by @torusrxxx) |
The stack is finally there! |
✅ Download x64dbg 1.0.1866 (commit 476db74b26 by @torusrxxx) |
🥳 will give it a try ASAP! |
✅ Download x64dbg 1.0.1867 (commit 40e9c822bf by @torusrxxx) |
✅ Download x64dbg 1.0.1870 (commit a3a59e37b1 by @torusrxxx) |
Xrefs dialog is added so you can quickly find out what accessed this memory location. Extremely easy and fast. |
✅ Download x64dbg 1.0.1871 (commit b12e9ee114 by @torusrxxx) |
✅ Download x64dbg 1.0.1873 (commit 0a1fb28928 by @torusrxxx) |
This fixes #2378
There's obviously a lot more to do. This pull request is here only for those who desperately want to dump from a trace or want to become alpha testers.
Right click on an instruction in the trace, and click the "Information" menu to get full dump of the trace up to the selected instruction into the log view.