[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep' #20224

rolfbjarne · 2024-02-29T15:34:47Z

Removing (and storing) the attributes earlier make it's possible for them not
to be marked. IOW the attribute type itself (and not just the decorations) can
be removed.

Inspired by / extracted from #14270.

Removing (and storing) the attributes earlier make it's possible for them not to be marked. IOW the attribute type itself (and not just the decorations) can be removed. Inspired by / extracted from xamarin#14270.

vs-mobiletools-engineering-service2 · 2024-05-06T09:38:54Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T09:42:44Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T09:44:04Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T09:47:10Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T09:48:35Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T10:14:17Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 759b7bef49f72e948a25ed12d343bae167bdc67c [PR build]

vs-mobiletools-engineering-service2 · 2024-05-06T11:00:36Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 43 tests failed, 68 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (macOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ framework tests

2 tests failed, 6 tests passed.

framework-test/tvOS - simulator/Debug: BuildFailure (Harness exception for 'framework-test': System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/builder/azdo/_work/2/s/xamarin-macios/tests/framework-test/iOS/generated-projects/tvos/framework-test-ios-tvos.csproj'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.PListExtensions.LoadWithoutNetworkAccess(XmlDocument doc, String filename) at Xharness.TestProject.CreateCopyAsync(ILog log, IProcessManager processManager, ITestTask test, String rootDirectory, Dictionary2 allProjectReferences) in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:line 98
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 260)
framework-test/watchOS 32-bits - simulator/Debug: BuildFailure (Harness exception for 'framework-test': System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/builder/azdo/_work/2/s/xamarin-macios/tests/framework-test/iOS/generated-projects/watchos/framework-test-ios-watchos.csproj'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.PListExtensions.LoadWithoutNetworkAccess(XmlDocument doc, String filename) at Xharness.TestProject.CreateCopyAsync(ILog log, IProcessManager processManager, ITestTask test, String rootDirectory, Dictionary2 allProjectReferences) in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:line 98
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 260)

Html Report (VSDrops) Download

❌ fsharp tests

2 tests failed, 5 tests passed.

fsharp/tvOS - simulator/Debug: BuildFailure (Harness exception for 'fsharp': System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/builder/azdo/_work/1/s/xamarin-macios/tests/fsharp/generated-projects/tvos/fsharp-tvos.fsproj'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.PListExtensions.LoadWithoutNetworkAccess(XmlDocument doc, String filename) at Xharness.TestProject.CreateCopyAsync(ILog log, IProcessManager processManager, ITestTask test, String rootDirectory, Dictionary2 allProjectReferences) in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/xharness/TestProject.cs:line 98
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 260)
fsharp/watchOS 32-bits - simulator/Debug: BuildFailure (Harness exception for 'fsharp': System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/builder/azdo/_work/1/s/xamarin-macios/tests/fsharp/generated-projects/watchos/fsharp-watchos.fsproj'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.PListExtensions.LoadWithoutNetworkAccess(XmlDocument doc, String filename) at Xharness.TestProject.CreateCopyAsync(ILog log, IProcessManager processManager, ITestTask test, String rootDirectory, Dictionary2 allProjectReferences) in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/xharness/TestProject.cs:line 98
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/1/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 260)

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 2 tests passed.

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ linker tests

20 tests failed, 7 tests passed.

dont link/Mac [dotnet]/Debug [dotnet]: BuildFailure
dont link/Mac [dotnet]/Release [dotnet]: BuildFailure
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
dont link/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
link sdk/Mac [dotnet]/Debug [dotnet]: BuildFailure
link sdk/Mac [dotnet]/Release [dotnet]: BuildFailure
link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
link sdk/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
link all/Mac [dotnet]/Debug [dotnet]: BuildFailure
link all/Mac [dotnet]/Release [dotnet]: BuildFailure
link all/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
link all/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
trimmode copy/Mac [dotnet]/Debug [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
trimmode copy/Mac [dotnet]/Release [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
trimmode copy/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
trimmode copy/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure
trimmode link/Mac [dotnet]/Debug [dotnet]: BuildFailure
trimmode link/Mac [dotnet]/Release [dotnet]: BuildFailure
trimmode link/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
trimmode link/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ mononative tests

1 tests failed, 0 tests passed.

mono-native-unified/Mac Modern/Debug: BuildFailure (Harness exception for 'mono-native-unified': System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/builder/azdo/_work/2/s/xamarin-macios/tests/mono-native/macOS/unified/mono-native-unified.csproj'.
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Boolean failForSymlink, Boolean& wasSymlink, Func4 createOpenException)
at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.PListExtensions.LoadWithoutNetworkAccess(XmlDocument doc, String filename) at Xharness.TestProject.CreateCopyAsync(ILog log, IProcessManager processManager, ITestTask test, String rootDirectory, Dictionary2 allProjectReferences) in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/TestProject.cs:line 98
at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync() in /Users/builder/azdo/_work/2/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:line 260)

Html Report (VSDrops) Download

❌ monotouch tests (MacCatalyst)

4 tests failed, 3 tests passed.

monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (NativeAOT, x64) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
monotouch-test/Mac Catalyst [dotnet]/Release (all optimizations) [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

4 tests failed, 4 tests passed.

monotouch-test/Mac [dotnet]/Release (NativeAOT, x64) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Release (NativeAOT) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
monotouch-test/Mac [dotnet]/Release (all optimizations) [dotnet]: BuildFailure
monotouch-test/Mac [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

5 tests failed, 6 tests passed.

monotouch-test/tvOS - simulator/Debug [dotnet]: Crashed
monotouch-test/tvOS - simulator/Debug: Crashed
monotouch-test/tvOS - simulator/Release (all optimizations) [dotnet]: BuildFailure
monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))
monotouch-test/tvOS - simulator/Release (NativeAOT, x64) [dotnet]: BuildFailure ( (failed to parse the logs: The Writer is closed or in error state.))

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
⚠️ monotouch (iOS): No tests selected. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne mentioned this pull request Mar 18, 2024

[linker] Remove more and earlier some attributes #14270

Closed

[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep'

759b7be

Removing (and storing) the attributes earlier make it's possible for them not to be marked. IOW the attribute type itself (and not just the decorations) can be removed. Inspired by / extracted from xamarin#14270.

rolfbjarne force-pushed the store-attributes branch from a2a8f79 to 759b7be Compare May 6, 2024 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep' #20224

[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep' #20224

rolfbjarne commented Feb 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

vs-mobiletools-engineering-service2 commented May 6, 2024

[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep' #20224

Are you sure you want to change the base?

[dotnet] Merge the 'RemoveAttributesStep' into the 'StoreAttributesStep' #20224

Conversation

rolfbjarne commented Feb 29, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented May 6, 2024

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented May 6, 2024

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented May 6, 2024

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented May 6, 2024

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

vs-mobiletools-engineering-service2 commented May 6, 2024

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented May 6, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented May 6, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (iOS)

❌ dotnettests tests (MacCatalyst)

❌ dotnettests tests (macOS)

❌ dotnettests tests (tvOS)

❌ framework tests

❌ fsharp tests

❌ introspection tests

❌ linker tests

❌ mononative tests

❌ monotouch tests (MacCatalyst)

❌ monotouch tests (macOS)

❌ monotouch tests (tvOS)

Successes