Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][Video] Fix Episode NFO parsing error (introduced in #24565). #25201

Merged
merged 1 commit into from
May 25, 2024

Conversation

78andyp
Copy link
Contributor

@78andyp 78andyp commented May 12, 2024

Description

Backport of #25198

As reported in the forum https://forum.kodi.tv/showthread.php?tid=377480.

Error introduced in #24565 (I cannot reproduce the problem I was attempting to fix).

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@CastagnaIT
Copy link
Collaborator

CastagnaIT commented May 12, 2024

on backport PR's please use title same of original PR otherwise is not understandable on git history, the best if you add also [backport] prefix (but not mandatory) the [Omega] is not useful since its already on the target branch

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Type: Backport v21 Omega labels May 12, 2024
@CastagnaIT CastagnaIT added this to the Omega 21.1 milestone May 12, 2024
@ksooo
Copy link
Member

ksooo commented May 12, 2024

I prefer [Omega] because this makes clear a) that it is a backport and b) to which branch. But we have no hard guideline for this.

@78andyp 78andyp changed the title [Omega][Video] Backport of #25198 [Backport][Video] Fix Episode NFO parsing error (introduced in #24565). May 12, 2024
@CastagnaIT
Copy link
Collaborator

CastagnaIT commented May 12, 2024

@ksooo its fine, anyway my main point was something like [xy] #3838 not so good to have in branch

@KarellenX
Copy link
Member

KarellenX commented May 12, 2024

Could someone kick off a Win64 test build for this. Thanks.
@fuzzard

@neo1973 neo1973 merged commit 973ce81 into xbmc:Omega May 25, 2024
2 checks passed
@78andyp 78andyp deleted the omega_nfofix branch May 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Backport Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-episode video & NFO files not being properly displayed (KODI 21.0 Omega) when using local information
5 participants