[Backport] [Joysticks] Fix mapping PS4 trigger analog semiaxes #25225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rapid input is dropped when buttonmapping, because some controllers send multiple events per button press with different button IDs. For example, on many PlayStation controllers, the triggers send an analog event, and a digital event when the trigger crosses about halfway. The 0.5 analog event arrives shortly before or shortly after the digital event. The bug: If the digital button is ignored, the analog event may be detected as rapid input and dropped. This is fixed by prioritizing the "IsIngored" check.
garbear
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #25175.
Motivation and context
Fix is broken out from #24604, as it doesn't touch Android.
How has this been tested?
Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases
What is the effect on users?
Types of change