Cache path vs Local path #602
Open
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
axrati
commented
Feb 24, 2024
1 similar comment
|
Xenova is currently overwhelmed with the release of v3, but will for sure review your PR as soon as possible. |
|
Thank you! Happy to help however I can (PR's / Issues / etc), please let me know how to contribute best 😃 |
|
Hi! This has been open for a bit... its a small change I promise :) Fixes issues in this issue (multiple people are experiencing): #520 |
|
Following up on this! Please let me know how to move forward with your merging process? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix an issue where providing a directory for a model in a different parent directory/tree results in an error.
There is a split handling between cache path and local path - mostly because I wasn't sure behind all use case implementations (browser vs local vs X). This solutions solves providing file paths such as
../../your_model_diras theenv.localModelPathvariable.