Allowing Single GPU with ID 0 - Bug Fix #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug that currently prevents the utilization of a single GPU with ID 0. Currently, the code includes a conditional check that inadvertently prevents the use of GPU 0 by not accounting for cases when the user explicitly passes GPU ID 0. The check is performed using the statement if gpu_id:, which unintentionally blocks GPU 0.
To resolve this issue, I propose modifying the check statement to if gpu_id and gpu_id != 0:. This adjustment ensures that the code will allow the use of GPU 0 while still appropriately handling cases where gpu_id is None.
This fix not only corrects the bug but also ensures compatibility with setups that involve a single GPU with ID 0. The modified condition will now consider both the non-null value of gpu_id and its non-equality to 0, thus enabling the correct behavior for single GPUs.