fix(PATH): push PATH updates into os.environ on change #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
force-pushed
the
gil/update_environ_path
branch
6 times, most recently
from
93a0d39
to
a6ebe19
Compare
gforsyth
force-pushed
the
gil/update_environ_path
branch
2 times, most recently
from
64b907d
to
9ba5e12
Compare
events needs to be free from as many internal dependencies as possible to allow early import
This issue was raised in xonsh#5050. If users (or `xontribs`) make use of `subprocess`, the `PATH` available to `subprocess` is the value of `PATH` in `os.environ`, which is set at the first import of `os.environ`. This means (meant) that if a user updates their `PATH` in `xonshrc`, those changes aren't visible to a bare `subprocess` call. (This is what `UPDATE_OS_ENVIRON` is nominally for, but since changes to `PATH` are mutating a mutable object, we don't hit any of the `__setitem__` checks in the env object). So, instead, I've added an explicit call to update the `os.environ` value of `PATH` after each mutating call to our `EnvPath` class, so this should also work for the various `_PATH` variables (e.g. `LDD_LIBRARY_PATH`).
gforsyth
force-pushed
the
gil/update_environ_path
branch
from
719cbfb
to
59cb5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was raised in
#5050.
If users (or
xontribs) make use ofsubprocess, thePATHavailableto
subprocessis the value ofPATHinos.environ, which is set atthe first import of
os.environ.This means (meant) that if a user updates their
PATHinxonshrc,those changes aren't visible to a bare
subprocesscall.(This is what
UPDATE_OS_ENVIRONis nominally for, but since changes toPATHare mutating a mutable object, we don't hit any of the__setitem__checks in the env object).So, instead, I've added an explicit call to update the
os.environvalue of
PATHafter each mutating call to ourEnvPathclass, so thisshould also work for the various
_PATHvariables (e.g.LDD_LIBRARY_PATH).For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment