-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for SCAT dataset #437
Conversation
Thank you so much, With reflexion, I see another alternative here: how about changing the Also about the test, do you mind writing something slightly more explicit for weather and waypoints, like the presence of some column in the dataframe? or an equality for the max of some value in a given column? This helps to ensure we get the proper columns we expect with these methods... |
Yes, good call. I think Sure, I can write some better tests when I’m back on office on Tuesday. |
I added some real test cases now. However, I wondered if just returning the waypoints as a large dataframe is really the best option, here. We do not have information other than Additionally, SCAT provides data to describe the airspace which could be parsed as well, I think. Let me know if you would want to keep this all in one PR or split it into multiple PRs. |
I dove a bit deeper into the navaids and rewrote it so that the scat dataset holds the points as a
in my opinion, this would be quite clean and more useful as it also helps with parsing the flight plans. |
Thanks! |
I just fixed the tests 😱 |
Hey there, thanks for merging! Sorry, the tests were still for the dataframe implementation, forgot to mention that in my comment 🙄. I am not familiar with xarray and its advantages, if it is only a |
As discussed here I added the engine flag to the eval calls. While I was at it, I also implemented some functions for loading the waypoints and weather data. Existing code should not break as I added the additional flags
include_weather
andinclude_waypoints
and set them toFalse
by default.Both weather and waypoints are just dataframes right now because there is some information missing from the waypoints which would be needed to make them Navaid objects. The weather data is decoded grib format which is different from the implemented metar data format.
Let me know what you think!
Thanks