Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Editing: Image Frames #4946

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

p0mm
Copy link
Contributor

@p0mm p0mm commented Jun 28, 2023

this PR was originally a response to #4183, i have since split it up into image insertion #4966 and Image Frames (this PR)!

Image Frames

General Idea:

  • edit image while it is inside the frame: allow images to be cut!
  • allow the user to plan for multiple images before inserting all of them in one go!
    -> make adding multiple images easier to plan
  • possibility to template?

Demo:

Progress.webm

Plans:

  • define space by dragging the mouse (click - drag - let go)
  • have a nice visual to see what space you are choosing
  • frame for image comes into existence
  • its size can be adjusted
  • it will remain if you save, close and open xournalpp again
  • allow multiple image frames to coexist
  • add image to the frame by clicking it
  • give a visual so this mechanic is easily understandable (show pointer as tiny image icon while hovering over image frame)
  • add image by dragging and dropping it into the frame
  • give different options on whether the image is scaled up, down or stretches and fills the space
  • have a default setting for these options available in the preferences
  • still keep a simple add image directly option easily available, by having this be a different tool!
  • turn image into frame by clicking it with the frame tool!
  • cut images down to fit the image frame
  • turn image frame into image
  • allow image frame to be cloned

p0mm added 3 commits June 28, 2023 17:38
you can select space by dragging the mouse instead of clicking; image is then scaled down; still missing some visual and more options
Image can be scaled up too; no scaling occurs if selected space is 0
@forgottosave
Copy link
Contributor

Awesome feature, would be great to have this! To actually be able to scale the image before inserting it really saves you the troubles of having a giant image covering the whole page.

@p0mm p0mm force-pushed the load_image_with_specific_size#4183 branch from 19ae754 to e9ca4f2 Compare July 11, 2023 08:49
p0mm added 2 commits July 12, 2023 17:39
they can contain images & be moved and scaled with the selection tool
currently working modes are 'fill' and 'scale down', with 'scale down' currently hardcoded in
allows imageFrames to be scaled without changing to selection tool;
re-rendering is (temporarily) done via (costly) short-cut, I still need to figure that out
@p0mm p0mm changed the title Enhanced Image Adding & Image Frames Enhanced Image Editing: Image Frames Jul 23, 2023
@p0mm p0mm changed the title Enhanced Image Editing: Image Frames Image Editing: Image Frames Jul 23, 2023
p0mm added 4 commits July 26, 2023 01:49
this will be used by the Image Frame, but is located in ImageView (because it makes sense) and Image (to remember the surface & not recreate it every time)
general update to how the ImageFrames look & they are drawing partial images
@p0mm p0mm force-pushed the load_image_with_specific_size#4183 branch from 9fcc4fd to 5bd1e19 Compare August 2, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants