New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Editing: Image Frames #4946
Draft
p0mm
wants to merge
12
commits into
xournalpp:master
Choose a base branch
from
p0mm:load_image_with_specific_size#4183
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can select space by dragging the mouse instead of clicking; image is then scaled down; still missing some visual and more options
Image can be scaled up too; no scaling occurs if selected space is 0
Awesome feature, would be great to have this! To actually be able to scale the image before inserting it really saves you the troubles of having a giant image covering the whole page. |
p0mm
force-pushed
the
load_image_with_specific_size#4183
branch
from
July 11, 2023 08:49
19ae754
to
e9ca4f2
Compare
they can contain images & be moved and scaled with the selection tool currently working modes are 'fill' and 'scale down', with 'scale down' currently hardcoded in
allows imageFrames to be scaled without changing to selection tool; re-rendering is (temporarily) done via (costly) short-cut, I still need to figure that out
p0mm
changed the title
Enhanced Image Adding & Image Frames
Enhanced Image Editing: Image Frames
Jul 23, 2023
p0mm
changed the title
Enhanced Image Editing: Image Frames
Image Editing: Image Frames
Jul 23, 2023
this will be used by the Image Frame, but is located in ImageView (because it makes sense) and Image (to remember the surface & not recreate it every time)
general update to how the ImageFrames look & they are drawing partial images
p0mm
force-pushed
the
load_image_with_specific_size#4183
branch
from
August 2, 2023 14:47
9fcc4fd
to
5bd1e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR was originally a response to #4183, i have since split it up into image insertion #4966 and Image Frames (this PR)!
Image Frames
General Idea:
-> make adding multiple images easier to plan
Demo:
Progress.webm
Plans: