Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5269
This is depending on two other things:
assert()
that has to be changed toxoj_assert()
for this)I have included the commits from the above points for now, so you can see / test the changes. I will rebase/do whatever, when we decide to move forward and have an appropriate base to merge upon. As such, the only really relevant commit here is the last one (017450c).
Question to maintainers: when should I open a PR for merging the commits of #5108 onto master? Now, when the other issue is cleared up, or not at all (merging them through this PR)?