Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zoom center #5295

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

tmoerschell
Copy link
Contributor

@tmoerschell tmoerschell commented Oct 27, 2023

Fixes #5269

This is depending on two other things:

I have included the commits from the above points for now, so you can see / test the changes. I will rebase/do whatever, when we decide to move forward and have an appropriate base to merge upon. As such, the only really relevant commit here is the last one (017450c).

Question to maintainers: when should I open a PR for merging the commits of #5108 onto master? Now, when the other issue is cleared up, or not at all (merging them through this PR)?

@bhennion
Copy link
Contributor

Question to maintainers: when should I open a PR for merging the commits of #5108 onto master? Now, when the other issue is cleared up, or not at all (merging them through this PR)?

I'll do it this weekend if you want.

@tmoerschell
Copy link
Contributor Author

Rebased onto master now. Thanks @bhennion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom center is not correct when it is not on the active page
2 participants