Keyboard Shortcuts: lay foundation for feature #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lay the foundation for a standard way to configure user defined keyboard shortcuts. Added "Shortcuts" settings tab which can write and retreive gtk accelerator-strings from core::control::Settings Shortcut key-values are stored as a std::unordered_map. I did not add any modification to ActionDatabase yet, and would like to get community feedback before. Refrences issue xournalpp#919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lay the foundation for a standard way to configure user defined keyboard shortcuts. Added "Shortcuts" settings tab which can write and retreive gtk accelerator-strings from core::control::Settings
Shortcut key-values are stored as a std::unordered_map.
I did not add any modification to ActionDatabase yet, and would like to get community feedback before.
(second commit because I forgot to clang-format)
Refrences issue #919