Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference settings for selection size #5468

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdujava
Copy link
Contributor

@jdujava jdujava commented Jan 20, 2024

Problem:
Selection can be sometimes unnecessarily big (mainly when working zoomed in). It would be suitable to have a preference setting for selection padding, such that one can adjust it according to their workflow.

Two options added:

  • SelectPaddingMult (to change selection padding)
  • ButtonSizeMult (to change size of selection buttons)

This is still WIP (need to add some tooltips and other small tweaks), but overall it seems to work pretty well.
I will gladly hear your thoughts on this.

Two options added:
* SelectPaddingMult (to change selection padding)
* ButtonSizeMult (to change size of selection buttons)
@bhennion
Copy link
Contributor

I'm not sure this is the right solution to the issue. I think the problem comes from the selection box padding not adapting to the zoom (i.e. there should be a padding of fixed screen dimension, not of fixed page coordinate dimension).
In any case, the whole selection business needs a complete overall -- split model-view-controller + optimize out a lot of useless computations (I have a draft in the making somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants