Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local daily updated Debian for release pipeline #5645

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LittleHuba
Copy link
Member

No description provided.

@LittleHuba LittleHuba marked this pull request as ready for review April 28, 2024 17:28
@LittleHuba LittleHuba changed the title Use debian:bookworm for release pipeline Use local daily updated Debian for release pipeline Apr 28, 2024
@LittleHuba
Copy link
Member Author

/azp run create-installers

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LittleHuba
Copy link
Member Author

The requested installers were generated successfully. The installers are available at:

Please be aware that these links are only valid for a limited time (~30 days).

@Febbe
Copy link
Collaborator

Febbe commented Apr 28, 2024

I would do this, after the release of 1.3.x. @bhennion, @rolandlo, is there something we should add in 1.x / 1.3.x before we start developing 2.0?

@Febbe
Copy link
Collaborator

Febbe commented Apr 28, 2024

lgtm

@rolandlo
Copy link
Member

Thanks @LittleHuba for taking the time.

@bhennion
Copy link
Contributor

I would do this, after the release of 1.3.x. @bhennion, @rolandlo, is there something we should add in 1.x / 1.3.x before we start developing 2.0?

Of the PR/issues tagged with the milestone, I'd say that #5528 should be merged first. For the rest, new features can wait 2.0 and bug fixes could go in 1.3.1.

@rolandlo
Copy link
Member

rolandlo commented Apr 29, 2024

I would do this, after the release of 1.3.x. @bhennion, @rolandlo, is there something we should add in 1.x / 1.3.x before we start developing 2.0?

Wouldn't it be better if @bhennion's preparation for Gtk4 PR's like #5602 and #5644 were part of 1.3.0?

For 1.2.4 I'd like to look into #5635 (which happens on Sonoma, but not on Catalina), since it would be better to fix this dark theme issue fully rather than in two steps. We should also wait for #5638 I think.

For 1.3.0 we may also need to decide what to do with #5273.

Edit: update after #5635 was fixed.

@Febbe
Copy link
Collaborator

Febbe commented Apr 30, 2024

Wouldn't it be better if @bhennion's preparation for Gtk4 PR's like #5602 and #5644 were part of 1.3.0?

Yes, the preparations should go into 1.X.
Features -> 1.3
Bugfixes -> 1.2.x

new features can wait 2.0

I am not sure here, many features will then wait a long time until they land in a stable release.
It depends on if they are features for us devs or features for the user.

E.g. rotating assets. It's a feature desired by many people. We just didn't add it, because it would've required a change for the file format.
But when we wait for the new file format that could again block 2.0 for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants