Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing a field entirely #1351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clearing a field entirely #1351

wants to merge 2 commits into from

Conversation

oarod
Copy link

@oarod oarod commented Jul 19, 2017

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets #1350
License MIT

Description

Pressing backspace/delete once more on an already empty field clears it entirely

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bed4605 on oarod:master into ** on yabwe:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 92060b1 on oarod:master into ** on yabwe:master**.

@j0k3r
Copy link
Contributor

j0k3r commented Jul 28, 2017

You mean empty an empty field? 🤔

@oarod
Copy link
Author

oarod commented Jul 28, 2017

I may have done a poor job of explaining this in the ticket. An "empty" field is currently <p><br></p>, but I need it to be entirely empty.

@zemlanin
Copy link

@j0k3r What blocks this PR?

Because of the current behavior, I need to write workarounds to check value of <textarea required> :/

@clemsontiger
Copy link

has this not been released yet?

@Hazantip
Copy link

Tag of the contenteditable element required to be an any html block except 'div'. In other case medium-editor automatically wraps content with a <p><br></p> if there is no content, or with <p></p> if there is a content in line

@blocknotes
Copy link

News about merging this one? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants