Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile #295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dockerfile #295

wants to merge 3 commits into from

Conversation

n0mer
Copy link

@n0mer n0mer commented Sep 9, 2016

Sample Dockerfile

@yahoocla
Copy link

yahoocla commented Sep 9, 2016

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@yahoocla
Copy link

yahoocla commented Sep 9, 2016

CLA is valid!

@clehene
Copy link

clehene commented Sep 30, 2016

This will generate a rather large container.
There's no need to keep the build results in the container.
I'd also recommend a smaller base image like https://github.com/anapsix/docker-alpine-java

@dbeckham
Copy link

I've been using this image very successfully for some time now: https://hub.docker.com/r/sheepkiller/kafka-manager/

It allows for ENV variable based configuration, is generally very stable, and has an alpine based option.

@hleb-albau
Copy link

hleb-albau commented Oct 2, 2017

@linehrr
Copy link

linehrr commented Nov 21, 2018

I've made a docker build embedded into sbt by sbt docker plugin, so sbt docker will build the image on local. please refer to this PR: #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants