[ie/taptap] Add new extractor for taptap.cn #9776
Open
+281
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seproDev
requested changes
May 9, 2024
seproDev
requested changes
May 21, 2024
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
seproDev
approved these changes
May 22, 2024
seproDev
added
pending-review
Grub4K
reviewed
May 22, 2024
10 tasks
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
Grub4K
approved these changes
May 23, 2024
bashonly
approved these changes
May 23, 2024
|
|
||
| # h265 playlist contains both h265 and h264 formats | ||
| video_url = traverse_obj(video_data, ('play_url', ('url_h265', 'url'), {url_or_none}, any)) | ||
| formats = self._extract_m3u8_formats(video_url, video_id) |
There was a problem hiding this comment.
this should be non-fatal or else 1 bad m3u8 url will break playlist extraction
Suggested change
| formats = self._extract_m3u8_formats(video_url, video_id) | |
| formats = self._extract_m3u8_formats(video_url, video_id, fatal=False) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Add support for video extraction from
taptap.cnposts and game topic pagesFixes #9643
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?