Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thirtydaysinger] Add Extractor #9894

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kieraneglin
Copy link

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds extractor for https://www.30daysinger.com.

This site uses Wistia so the the extractor inherits from the existing WistiaIE, but it doesn't share the URL structure expected by WistiaIE or TeachableIE. Even if I modify these extractors to parse 30daysinger URLs, they don't extract the title or description metadata properly.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@bashonly bashonly added site-request Request to support a new website pending-fixes PR has had changes requested labels May 9, 2024
yt_dlp/extractor/thirtydaysinger.py Outdated Show resolved Hide resolved
yt_dlp/extractor/thirtydaysinger.py Outdated Show resolved Hide resolved


class ThirtyDaySingerIE(ThirtyDaySingerBase):
_VALID_URL = r'https?://www\.30daysinger\.com/tutorial/[\w-]+/[\w-]+'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For viz: I'm not creating a match group for the video index here since that's handled in ThirtyDaySingerBase. Doing it this way allows me to share the logic between the video and playlist extractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-fixes PR has had changes requested site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants