Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/beacon] Add extractor for Beacon.tv #9901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Deukhoofd
Copy link

@Deukhoofd Deukhoofd commented May 10, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Add an extractor to support downloading from https://beacon.tv, a new media website launched by Critical Role yesterday.

This website places a JSON in an HTML tag with a specific ID and type. This tag is extracted, the JSON is parsed, and the m3u8 URL and metadata are retrieved from the JSON.

Authentication on the site is done through cookies. This means that downloading videos that require authentication currently depends on the --cookies-from-browser command line flag. Videos that are public can be downloaded without this flag.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • [x ] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@Deukhoofd
Copy link
Author

Abandoning, as I just realized there's a way cleaner method to do what it needs to do.

@Deukhoofd Deukhoofd closed this May 10, 2024
@bashonly
Copy link
Member

bashonly commented May 10, 2024

You can push to the same branch and repurpose/reopen this PR

@bashonly bashonly added site-request Request to support a new website closed-pr (Partially) valid PR that was closed by OP labels May 10, 2024
@Deukhoofd
Copy link
Author

Nevermind the earlier message. I tried to use the Beacon API at https://beacon.tv/api/graphql. This works generally, and would simplify the flow of the code a lot. Unfortunately, for authenticated requests this requires an authentication token. This token is not retrievable from cookies, and requires a fairly complicated Oauth flow (using Memberful, a Wordpress plugin). This flow involves captions and other annoyances I wasn't able to work around.

While the direct API handling would have been a lot nicer, scraping the information from the HTML also functions. As such this should be fine for now.

@Deukhoofd Deukhoofd reopened this May 10, 2024
@seproDev seproDev removed the closed-pr (Partially) valid PR that was closed by OP label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants