Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC-334] YB Voyager v1.7 #22242

Merged
merged 17 commits into from May 16, 2024
Merged

[DOC-334] YB Voyager v1.7 #22242

merged 17 commits into from May 16, 2024

Conversation

aishwarya24
Copy link
Collaborator

No description provided.

@aishwarya24 aishwarya24 added the area/documentation Documentation needed label May 2, 2024
@aishwarya24 aishwarya24 self-assigned this May 2, 2024
@aishwarya24 aishwarya24 added this to In progress in Documentation via automation May 2, 2024
@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited

✅ Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4eb1416
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/6645ed510e1375000774374f
😎 Deploy Preview https://deploy-preview-22242--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aishwarya24 aishwarya24 marked this pull request as ready for review May 10, 2024 20:39
sanyamsinghal
sanyamsinghal reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@sanyamsinghal sanyamsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Migration Assessment related part of the doc.

docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated Show resolved Hide resolved
docs/content/preview/yugabyte-voyager/reference/assess-migration.md Show resolved Hide resolved
makalaaneesh
makalaaneesh approved these changes May 13, 2024
View reviewed changes
Copy link

@makalaaneesh makalaaneesh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

priyanshi-yb
priyanshi-yb reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few other changes -

  1. Add these two flags in export schema reference section -
--assessment-report-path string     path to the generated assessment report file(JSON format) to be used for applying recommendation to exported schema
 --skip-recommendations boolean      disable applying recommendations in the exported schema suggested by the migration assessment report; accepted values (true, false, yes, no, 0, 1)
  1. Add PostgreSQL to the list of the supported databases in all mentions of Live migration with fall-back on overview page.

docs/content/preview/yugabyte-voyager/migrate/live-fall-back.md
@@ -546,7 +1048,7 @@ yb-voyager import schema --export-dir <EXPORT_DIR> \
--post-snapshot-import true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please remove this Important note from all the live migration workflows in the Prepare the target database step -

{{<note title="Important">}}
Add the following flags to the cluster before starting migration, and revert them after the migration is complete.
...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aishwarya24 can you please revert this change, we discussed that it's better to keep this note for one release and will remove later on.
Cc: @makalaaneesh

docs/content/preview/yugabyte-voyager/reference/assess-migration.md Show resolved Hide resolved
@aishwarya24
Copy link
Collaborator Author

--skip-recommendations

@priyanshi-yb - Is there a default for this?

@priyanshi-yb
Copy link
Contributor

@priyanshi-yb - Is there a default for this?

@aishwarya24 yes it's default false.

shubham-yb
shubham-yb reviewed May 15, 2024
View reviewed changes
docs/content/preview/yugabyte-voyager/migrate/assess-migration.md Outdated
1. Run the `yb-voyager-pg-gather-assessment-metadata.sh` script by providing the source connection string, the schema names, and path to a directory where metadata will be saved. For example,

```sh
/path/to/yb-voyager-pg-gather-assessment-metadata.sh 'postgresql://ybvoyager@host:port/dbname' 'schema1|schema2' '/path/to/assessment_metadata_dir'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not mentioning IOPS interval here @priyanshi-yb @aishwarya24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can be added here:

@aishwarya24, update this step -

  1. Run the yb-voyager-pg-gather-assessment-metadata.sh script by providing the source connection string, the schema names, path to a directory where metadata will be saved, and an optional argument of an interval to capture the IOPS metadata of the source (in seconds with a default value of 120 seconds). For example,
/path/to/yb-voyager-pg-gather-assessment-metadata.sh 'postgresql://ybvoyager@host:port/dbname' 'schema1|schema2' '/path/to/assessment_metadata_dir' '60'

priyanshi-yb
priyanshi-yb reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comment

docs/content/preview/yugabyte-voyager/migrate/live-fall-back.md Show resolved Hide resolved
@aishwarya24 aishwarya24 merged commit fab4cd0 into yugabyte:master May 16, 2024
2 checks passed
jharveysmith pushed a commit that referenced this pull request May 24, 2024
@aishwarya24
[DOC-334] YB Voyager v1.7 (#22242)
02afe58 
* first set of changes for v1.7

* updates to tabs

* added pg options for fall-back

* all updates added, assess migration pending

* assess migration content added

* removed files

* review comments addressed

* minor edits and changes from review

* review comments

* added release notes and assessment image

* added more release notes and version updates for target db

* more changes from review

* added pg known issue and unsupported pg issue

* review comments

* added schema list to another fall back query

* changed date

* changed date
svarnau pushed a commit that referenced this pull request May 25, 2024
@aishwarya24
[DOC-334] YB Voyager v1.7 (#22242)
511449a 
* first set of changes for v1.7

* updates to tabs

* added pg options for fall-back

* all updates added, assess migration pending

* assess migration content added

* removed files

* review comments addressed

* minor edits and changes from review

* review comments

* added release notes and assessment image

* added more release notes and version updates for target db

* more changes from review

* added pg known issue and unsupported pg issue

* review comments

* added schema list to another fall back query

* changed date

* changed date
svarnau pushed a commit that referenced this pull request May 25, 2024
@aishwarya24
[DOC-334] YB Voyager v1.7 (#22242)
b39ead6 
* first set of changes for v1.7

* updates to tabs

* added pg options for fall-back

* all updates added, assess migration pending

* assess migration content added

* removed files

* review comments addressed

* minor edits and changes from review

* review comments

* added release notes and assessment image

* added more release notes and version updates for target db

* more changes from review

* added pg known issue and unsupported pg issue

* review comments

* added schema list to another fall back query

* changed date

* changed date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makalaaneesh makalaaneesh makalaaneesh approved these changes

@sanyamsinghal sanyamsinghal sanyamsinghal left review comments

@shubham-yb shubham-yb shubham-yb left review comments

@priyanshi-yb priyanshi-yb priyanshi-yb left review comments

@ymahajan ymahajan Awaiting requested review from ymahajan

Assignees

@aishwarya24 aishwarya24

Labels
area/documentation Documentation needed
Projects
Documentation
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aishwarya24 @priyanshi-yb @makalaaneesh @sanyamsinghal @shubham-yb