Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer count in autoencoder detector #516

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

summeraz
Copy link

Resolves #138
Resolves #146
Resolves #254

This PR fixes a problem with the number of layers in the AutoEncoder detector. In the current master, the input layer is duplicated due to a bug in the loop where the hidden layers are added. The issue is fixed here. I have also added a test to ensure that the number of layers matches expectations.

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

@summeraz
Copy link
Author

Hey @yzhao062, sorry for jumping in unannounced with this. I have been using the AutoEncoder detector in pyod recently (awesome library you've created!) and noticed a problem with the number of layers in the model. Browsing through the issues, it seems several others have noticed this as well. The fix was easy, so I figured I would open a PR and add a test.

@yzhao062
Copy link
Owner

sorry for being late on this~ I was in moving from my PhD to new faculty job and was totally losing track on this. Could you resubmit this PR to the development branch? I am not back to this!

@summeraz summeraz changed the base branch from master to development November 5, 2023 03:36
@summeraz
Copy link
Author

summeraz commented Nov 5, 2023

No problem. I've changed the base branch to the development branch. I don't see any automatic CI test runs, so I'll close and reopen to see if that triggers them. Edit: No 😢

@summeraz summeraz closed this Nov 5, 2023
@summeraz summeraz reopened this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants