Improve trip count estimation in statistics passes #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andidr
force-pushed
the
andi/statistics
branch
2 times, most recently
from
7986272
to
e64c62d
Compare
For `ExtractSliceOp` and `InsertSliceOp`, the code performing the hoisting of indexed operations in the batching pass derives the indexes of the hoisted operation from the indexes provided by `ExtractSliceOp::getOffsets()` and `InsertSliceOp::getOffsets()`. However, these methods only return dynamic indexes, such that operations with mixed, dynamic and static offsets are hoisted incorrectly. This patch replaces the invocations of `ExtractSliceOp::getOffsets()` and `InsertSliceOp::getOffsets()` with invocations of `ExtractSliceOp::getMixedOffsets()` and `InsertSliceOp::getMixedOffsets()`, respectively in order to take into account both static and dynamic indexes.
andidr
force-pushed
the
andi/statistics
branch
3 times, most recently
from
eaa4857
to
6ebee7a
Compare
…ics passes This makes the trip counts of operations in the TFHE statistics pass as well as the per-location memory usage statistics in the memory usage statistics pass optional. These values are unset if the trip count could not be determined statically.
BourgerieQuentin
approved these changes
Sep 25, 2023
| int64_t ub; | ||
| int64_t step; | ||
|
|
||
| bool isStatic = isStaticLoop(forOp, &lb, &ub, &step); |
There was a problem hiding this comment.
should be in the assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.