This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
[major] logout by only killing one key, not all #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
changed the title
xavdid
commented
May 22, 2019
| try { | ||
| await utils.callAPI('/keys', { | ||
| method: 'DELETE' | ||
| method: 'DELETE', | ||
| body: { single: true } |
There was a problem hiding this comment.
this is the only actual code change
xavdid
commented
May 22, 2019
| const requestBody = JSON.parse(requestOptions.body); | ||
| const cleanedBody = {}; | ||
| for (const k in requestBody) { | ||
| if (k.includes('zip_file')) { |
There was a problem hiding this comment.
this prevents adding a zip_file key when there wasn't one before. I was super confused as to why my DELETE call had 2 zips attached.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
zapier logoutdeactivated all keys. That's odd behavior, so we're doing to make it only kill the active key. This relies on some server work that's not done yet, so there's not much to see yet. Also did some unrelated logging improvements.