Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serendipity extension #733

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

meocoder31099
Copy link
Contributor

@meocoder31099 meocoder31099 commented May 16, 2024

This adds the serendipity theme extension from https://github.com/meocoder31099/Serendipity-Theme-Zed

Copy link

cla-bot bot commented May 16, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @meocoder31099 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@meocoder31099
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label May 16, 2024
Copy link

cla-bot bot commented May 16, 2024

The cla-bot has been summoned, and re-checked this pull request!

@valentinegb
Copy link
Contributor

valentinegb commented May 17, 2024

.gitmodules must be sorted for the CI to pass

diff --git a/.gitmodules b/.gitmodules
index f15e1fd..7666910 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -426,6 +426,10 @@
 	path = extensions/scss
 	url = https://github.com/bajrangCoder/zed-scss.git
 
+[submodule "extensions/serendipity"]
+	path = extensions/serendipity
+	url = https://github.com/meocoder31099/Serendipity-Theme-Zed
+
 [submodule "extensions/siri"]
 	path = extensions/siri
 	url = https://github.com/perragnar/zed-theme-siri.git
@@ -601,7 +605,3 @@
 [submodule "extensions/zedwaita"]
 	path = extensions/zedwaita
 	url = https://github.com/someone13574/zed-adwaita-theme.git
-
-[submodule "extensions/serendipity"]
-	path = extensions/serendipity
-	url = https://github.com/meocoder31099/Serendipity-Theme-Zed

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxdeviant maxdeviant merged commit 651c41a into zed-industries:main May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants