Supermaven #10788
Merged
Supermaven #10788
+2,242
−827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
rgbkrk
force-pushed
the
supermaven
branch
2 times, most recently
from
e81b729
to
4e7dc91
Compare
rgbkrk
commented
Apr 23, 2024
rgbkrk
commented
Apr 23, 2024
rgbkrk
commented
Apr 23, 2024
rgbkrk
force-pushed
the
supermaven
branch
6 times, most recently
from
83e10cc
to
f7a5acb
Compare
rgbkrk
force-pushed
the
supermaven
branch
6 times, most recently
from
f34ccdc
to
2c78ee2
Compare
Co-Authored-By: Kyle <kylek@zed.dev> Co-Authored-By: Nathan <nathan@zed.dev>
Invert the dependency between copilot and editor This should help us merge the `copilot_ui` and `copilot` crates too.
* Improve UI parity on icons with copilot provider * Expose the service tier to `Supermaven` handler Co-authored-by: Max <max@zed.dev>
Co-Authored-By: Max <max@zed.dev>
Co-Authored-By: Max <max@zed.dev>
… working again Co-authored-by: Kyle <kylek@zed.dev>
Next, we'll rename the `copilot_ui` crate to make it provide a status bar menu for both copilot and supermaven Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-Authored-By: Nathan <nathan@zed.dev> Co-Authored-By: Max <max@zed.dev>
|
Nice! I was able to enable Supermaven with the new |
williamdes
reviewed
May 8, 2024
Comment on lines
+114
to
+130
| div().child( | ||
| popover_menu("copilot") | ||
| .menu(move |cx| { | ||
| Some(match status { | ||
| Status::Authorized => { | ||
| this.update(cx, |this, cx| this.build_copilot_context_menu(cx)) | ||
| } | ||
| _ => this.update(cx, |this, cx| this.build_copilot_start_menu(cx)), | ||
| }) | ||
| }) | ||
| .anchor(AnchorCorner::BottomRight) | ||
| .trigger( | ||
| IconButton::new("copilot-icon", icon) | ||
| .tooltip(|cx| Tooltip::text("GitHub Copilot", cx)), | ||
| ), | ||
| ) | ||
| } |
There was a problem hiding this comment.
I guess this introduced this bug #11537
SomeoneToIgnore
added a commit
that referenced
this pull request
May 8, 2024
Fixes prettier entries disappeared after #10788 Release Notes: - N/A
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
Fixes prettier entries disappeared after zed-industries#10788 Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a supermaven provider for completions. There are various other refactors amidst this branch, primarily to make copilot no longer a dependency of project as well as show LSP Logs for global LSPs like copilot properly.
This feature is not enabled by default. We're going to seek to refine it in the coming weeks.
Release Notes: