Enable random_channel_buffer_tests to run on Linux #10863
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @testmaxli on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
kain88-de
force-pushed
the
random-buffer-tests-linux
branch
from
a92a494
to
1f00e1f
Compare
cla-bot
bot
added
the
cla-signed
kain88-de
force-pushed
the
random-buffer-tests-linux
branch
from
0940629
to
4e56b5d
Compare
|
When do you plan to run the unit tests on linux? |
Probably as we get closer to a full Linux release. I'm not sure what the current state of the tests is. |
With this patch applied I can see the following line in the test output: test tests::random_channel_buffer_tests::test_random_channel_buffers has been running for over 60 seconds Without it I run in a failure wit 'Invalid keystroke `cmk-,`
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
kain88-de
force-pushed
the
random-buffer-tests-linux
branch
from
4e56b5d
to
b6a4eca
Compare
|
Currently 38 tests fail with this patch applied. I assume most of those are similar issues. I can work a bit on fixing them. I would feel better about that if the CI runs the tests to ensure they are not broken again in the future. Ideally all new test would also pass on Linux. However, do you want this at the moment? |
I'm not sure that we're ready to enable Linux tests in CI quite yet. |
) With this patch applied I can see the following line in the test output: test tests::random_channel_buffer_tests::test_random_channel_buffers has been running for over 60 seconds Without it I run in a failure with 'Invalid keystroke `cmk-,` Release Notes: - N/A --------- Co-authored-by: Max Linke <kain88-de@users.noreply.github.com> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
With this patch applied I can see the following line in the test output:
test tests::random_channel_buffer_tests::test_random_channel_buffers has been running for over 60 seconds
Without it I run in a failure with 'Invalid keystroke
cmk-,Release Notes: