Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in Rosé Pine theme #11018

Closed

Conversation

ThatOneCalculator
Copy link
Contributor

@ThatOneCalculator ThatOneCalculator commented Apr 26, 2024

For after zed-industries/extensions#630

Release Notes:

  • Removes the built-in Rosé Pine theme in favor of the official theme extension

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 26, 2024
@ThatOneCalculator
Copy link
Contributor Author

@zed-industries-bot recheck

@maxdeviant maxdeviant changed the title remove rose_pine built in zed theme Remove built-in Rosé Pine theme Apr 26, 2024
@maxdeviant maxdeviant self-assigned this Apr 26, 2024
@maxdeviant
Copy link
Member

We'll need to discuss internally what the plan is for the old themes.

One idea that was being considered was pulling the current built-in themes that get replaced into a separate "Zed Classic Themes" extension (or similar) so that anyone who prefers the current themes can use them.

So I don't think we're ready to remove the Rosé Pine themes just yet.

Installing the extension will overwrite the built-in ones, so it shouldn't prevent anyone from using the official themes.

@maxdeviant
Copy link
Member

Going to close this until we decide what the plans are for the built-in themes.

@maxdeviant maxdeviant closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants