Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix canonicalize return UNC path #11083

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented Apr 27, 2024

In Windows platform, using notify to watch file events.

  1. in notify windows implement, we get the full file path, just with path.join(file_path).
  2. In zed worktree start_backgroud_scan_tasks, abs_path is not unc path, so we get all file events with not unc path.
  3. but in zed worktree process_event, we strip_prefix unc path all times, it will always print annoy error.

@mikayla-maki I can't reopen pre closed pr #10501 .

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 27, 2024
@CharlesChen0823 CharlesChen0823 changed the title Fixed windows fs canonicalize Windows: Fix canonicalize return UNC path Apr 27, 2024
@CharlesChen0823
Copy link
Contributor Author

gpui::platform::windows::prompt_for_paths return not unc path, but i don't think here return unc path is better choice.

@mikayla-maki mikayla-maki marked this pull request as ready for review May 6, 2024 20:26
@mikayla-maki mikayla-maki marked this pull request as draft May 6, 2024 20:26
@mikayla-maki
Copy link
Contributor

mikayla-maki commented May 6, 2024

@CharlesChen0823 is this PR ready to go? The current fix looks a lot better and I'd be down to merge it :)

@CharlesChen0823 CharlesChen0823 marked this pull request as ready for review May 7, 2024 00:20
@CharlesChen0823
Copy link
Contributor Author

@mikayla-maki yes, it's ready for review.

@mikayla-maki
Copy link
Contributor

thank you!

@mikayla-maki mikayla-maki merged commit 843d299 into zed-industries:main May 7, 2024
12 of 14 checks passed
@CharlesChen0823 CharlesChen0823 deleted the fixed_windows_fs_canonicalize branch May 8, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants