editor: Support walking through overlapping diagnostics #11139
Merged
+45
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
kahlstrm
force-pushed
the
main
branch
2 times, most recently
from
cf0de4f
to
42e2c1a
Compare
maxdeviant
changed the title
Generated by 🚫 dangerJS against a728dd0d1ac7686e256ff9560125d02bcd7a7349 |
kahlstrm
force-pushed
the
main
branch
3 times, most recently
from
f017132
to
a728dd0
Compare
|
@osiewicz Mind taking a quick look at this one? |
|
Could you share your eslint config? I'd like to play with this branch locally. |
The file I was playing around in was this one, but those two files should work the same regardless of exact file |
osiewicz
pushed a commit
to RemcoSmitsDev/zed
that referenced
this pull request
May 18, 2024
…es#11139) While looking into how to implement zed-industries#4901, noticed that the current `Goto next/previous diagnostic` behaved a bit weirdly. That is, when there are multiple errors that have overlapping ranges, only the first one can be chosen to be active by the `go_to_diagnostic_impl`. ### Previous behavior: https://github.com/zed-industries/zed/assets/71292737/95897675-f5ee-40e5-869f-0a40066eb8e3 Doesn't go through all the diagnostics, and going backwards and forwards doesn't show the same diagnostic always. ### New behavior: https://github.com/zed-industries/zed/assets/71292737/81f7945a-7ad8-4a34-b286-cc2799b10500 Should always go through the diagnostics in a consistent manner. Release Notes: * Improved the behavioral consistency of "Go to Next/Previous Diagnostic"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into how to implement #4901, noticed that the current
Goto next/previous diagnosticbehaved a bit weirdly. That is, when there are multiple errors that have overlapping ranges, only the first one can be chosen to be active by thego_to_diagnostic_impl.Previous behavior:
Screen.Recording.2024-04-28.at.21.34.29.mov
Doesn't go through all the diagnostics, and going backwards and forwards doesn't show the same diagnostic always.
New behavior:
go_to_diagnostic_after.mov
Should always go through the diagnostics in a consistent manner.
Release Notes: