Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignoring soft wraps when moving to line ends #11153

Merged
merged 9 commits into from
May 2, 2024
Merged

Allow ignoring soft wraps when moving to line ends #11153

merged 9 commits into from
May 2, 2024

Commits on May 2, 2024

  1. Add stop_at_soft_wraps for begin/end of line move 

    This allows configuring whether moving to the beginning or end of a line
(for example, with the Home/End) keys should stop at soft wraps or not.

By default, this is false -- i.e., movement to the beginning or end of a
line will move to the logical position, rather than the position
dictated by the nearest soft wrap.
    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b443e40 View commit details
    Browse the repository at this point in the history

  2. Fix move to line beginning/end behavior 

    Respect the `stop_at_soft_wraps` field for both
`Editor::move_to_beginning_of_line` and `Editor::move_to_end_of_line`.

This changes the default behavior: previously, this would set the cursor
at the nearest soft wrap location in the respective direction. Now, it
will set the cursor properly at the logical beginning/end by default.
    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    98581aa View commit details
    Browse the repository at this point in the history

  3. Fix struct usage in tests

    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7e8e245 View commit details
    Browse the repository at this point in the history

  4. Refactor default_true to module

    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a0cea2e View commit details
    Browse the repository at this point in the history

  5. Default true for stop_at_soft_wraps 

    Previously, this setting would default to `false` when navigating to
line ends. Now, it will default to true.
    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    aaff932 View commit details
    Browse the repository at this point in the history

  6. Sort impl_actions section

    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4fd07e8 View commit details
    Browse the repository at this point in the history

  7. Add tests

    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c631579 View commit details
    Browse the repository at this point in the history

  8. Make CI tests happy

    @tverghis
    tverghis committed May 2, 2024
    Configuration menu
    Copy the full SHA
    125b6cc View commit details
    Browse the repository at this point in the history

  9. Make tests work on mac CI

    @SomeoneToIgnore
    SomeoneToIgnore committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a1f241e View commit details
    Browse the repository at this point in the history