Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy path and copy relative path to context click menu #11181

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented Apr 29, 2024

Release Notes:

  • Added "Copy path" and "Copy relative path" to the file right click context menu

Related to #4474

This replicates the tab behavior that exists on vscode
image

Tasks:

  • Check that it works on context menu in file
    image
    - [ ] Check that it works on a tab (does nothing)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 29, 2024
@williamdes williamdes force-pushed the add-copy-path-copy-relative-path-to-menus branch from 91dc9a3 to 2e89e47 Compare May 4, 2024 08:20
@williamdes williamdes changed the title Add copy path and copy relative path to context click menu and tab menu Add copy path and copy relative path to context click menu May 4, 2024
@williamdes williamdes marked this pull request as ready for review May 4, 2024 08:29
@williamdes
Copy link
Contributor Author

I only implemented for the context menu in a file, I am unable to make it work for a tab. It is better to merge this one without the tab click. Maybe someone will make it or help me do it some day :)

@mikayla-maki
Copy link
Contributor

It doesn't seem like VSCode includes this in it's mouse context menu:

Screenshot 2024-05-06 at 2 05 25 PM

As such, I don't think this is the right place for this action contextually. It should be on the tabs and the project panel.

@williamdes
Copy link
Contributor Author

As such, I don't think this is the right place for this action contextually. It should be on the tabs and the project panel.

I tend to agree but failed implementing it.
Could someone let me know why my action was doing nothing?

@mikayla-maki
Copy link
Contributor

Without a code sample or otherwise looking at the problem, I couldn't tell you. I suggest jumping in our discord and asking once you have one though :)

@williamdes
Copy link
Contributor Author

Could you send me an invite link?

Here was my implementation 91dc9a3

@mikayla-maki
Copy link
Contributor

Hmmm, it should be available somewhere? Regardless, here's the link: https://discord.gg/29HzRq8V

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants