Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: Fix language server installation on Windows #11251

Merged
merged 2 commits into from
May 3, 2024

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented May 1, 2024

Release Notes:

  • N/A

Follow #11156, to make sure extensions install on window.

https://github.com/tamasfe/taplo/releases/tag/0.8.1

The Taplo have gz for windows, so we can just use gz.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 1, 2024
@huacnlee huacnlee marked this pull request as ready for review May 1, 2024 15:36
@maxdeviant maxdeviant self-assigned this May 1, 2024
extensions/toml/src/toml.rs Outdated Show resolved Hide resolved
@huacnlee
Copy link
Contributor Author

huacnlee commented May 1, 2024

image

@maxdeviant maxdeviant changed the title Fix toml extension lsp install on Windows tom: Fix language server installation on Windows May 3, 2024
@maxdeviant maxdeviant changed the title tom: Fix language server installation on Windows toml: Fix language server installation on Windows May 3, 2024
@maxdeviant maxdeviant merged commit beee79a into zed-industries:main May 3, 2024
8 checks passed
@maxdeviant
Copy link
Member

@huacnlee Thank you!

@maxdeviant maxdeviant mentioned this pull request May 3, 2024
maxdeviant added a commit that referenced this pull request May 3, 2024
This PR bumps the TOML extension to v0.1.1.

Changes:

- #11251

Release Notes:

- N/A
@huacnlee huacnlee deleted the fix-toml-on-windows branch May 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants