Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gql and .graphqls extensions for GraphQL icon #12073

Merged
merged 1 commit into from
May 21, 2024

Conversation

anilsenay
Copy link
Contributor

@anilsenay anilsenay commented May 21, 2024

There are .gql and .graphqls suffix support in GraphQL VSCode extension. I use those file extensions in my projects, hence I wanted them to be graphql icons.

Release Notes:

  • Added GraphQL icon for .gql and .graphqls files.

currently:
resim

after this pr:
resim

in vscode:
resim

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 21, 2024
@maxdeviant
Copy link
Member

Is .graphqls a standard GraphQL extension?

@anilsenay
Copy link
Contributor Author

anilsenay commented May 21, 2024

Is .graphqls a standard GraphQL extension?

Actually I am not sure if it is a standard but I saw it in several docs:

@maxdeviant maxdeviant changed the title Add gql and graphqls suffixes for graphql icon Add .gql. and .graphqls` extensions for GraphQL icon May 21, 2024
@maxdeviant maxdeviant changed the title Add .gql. and .graphqls` extensions for GraphQL icon Add .gql and .graphqls extensions for GraphQL icon May 21, 2024
@maxdeviant maxdeviant self-assigned this May 21, 2024
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit ba1d28f into zed-industries:main May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants