Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: samples: philosophers: Clean up README #72878

Merged
merged 2 commits into from
May 31, 2024

Conversation

Wrap at 100 characters

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben force-pushed the philo branch 3 times, most recently from a799f4c to b75bbdb Compare May 16, 2024 14:03
Improved the formatting of the overview and fixed minor
grammar issues

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben marked this pull request as ready for review May 16, 2024 16:19
@zephyrbot zephyrbot added the area: Samples Samples label May 16, 2024
@zephyrbot zephyrbot requested a review from nashif May 16, 2024 16:20
@kartben kartben requested a review from gmarull May 16, 2024 16:22
@kartben kartben requested a review from aescolar May 30, 2024 17:42
Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Sidenote: I'm thinking we should not reformat lines from 80 to 100 chars, otherwise we are going to be changing a lot of lines.

@kartben
Copy link
Collaborator Author

kartben commented May 31, 2024

Thanks. Sidenote: I'm thinking we should not reformat lines from 80 to 100 chars, otherwise we are going to be changing a lot of lines.

Ya I tend to agree but my thinking here was that the file was already inconsistent, with some sections already going past 80.
In fact, if we were to implement a change, I think I'd like to see us use a no line wrap policy, and rather have do one sentence/one line. This way, diffs are much cleaner when e.g one just adds a few words to a sentence, only that one line is changed as opposed to potentially many as everything in the paragraph gets "pushed".

@carlescufi carlescufi merged commit adfa334 into zephyrproject-rtos:main May 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants