tests: mcuboot: add boot_request_upgrade() return value check #72883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
butok
commented
May 16, 2024
butok
commented
- Adds boot_request_upgrade() return value check.
- Avoid repeating resets if the upgrade request fails.
- Adds boot_request_upgrade() return value check. - Avoid repeating resets if the upgrade request fails. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
butok
force-pushed
the
check_return_request_upgrade
branch
from
2f9710d
to
5b04c66
Compare
danieldegrasse
approved these changes
May 16, 2024
dleach02
added
the
Trivial
dleach02
approved these changes
May 17, 2024
|
@butok I meet failure on lpcexpresso55s36 |
nordicjm
approved these changes
May 17, 2024
| printk("Failed to request upgrade: %d", err); | ||
| } else { | ||
| printk("Secondary application ready for swap, rebooting\n"); | ||
| sys_reboot(SYS_REBOOT_COLD); |
There was a problem hiding this comment.
Might be worth adding a k_sleep() here for 200ms or so to ensure message is printed (optional)
There was a problem hiding this comment.
Might be worth adding a k_sleep() here for 200ms or so to ensure message is printed (optional)
It 's not needed. It is printed on all tested platforms.
Tested on other LPC55S69, and it is fine. After mass erase (Jlink), LPC55S36 also passed (Debug messages are enabled): |
|
ok, maybe my board issue atagin. |
hakehuang
approved these changes
May 18, 2024
|
Hi @d3zd3z , PR is waiting for you. |
de-nordic
approved these changes
May 23, 2024
d3zd3z
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.