Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: nxp: rd_rw612_bga: add support for goworld 16880 display module #72899

Merged

Conversation

danieldegrasse
Copy link
Collaborator

Add support for the goworld 16880 display module. As this display module only features an FFC cable, it is added as a board overlay for the RW612 BGA. This module uses an ST7796S display controller as well as an FT7401 touch controller (which is managed by the FT5336 input driver)

Add support for the goworld 16880 display module. As this display module
only features an FFC cable, it is added as a board overlay for the RW612
BGA. This module uses an ST7796S display controller as well as an FT7401
touch controller (which is managed by the FT5336 input driver)

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
@dleach02
Copy link
Member

can this display also work with the frdm_rw612 board?

@danieldegrasse
Copy link
Collaborator Author

can this display also work with the frdm_rw612 board?

In theory it can work with any board that has a SPI interface. The reason I defined this display module for the RW board specifically is because I think it has limited use outside of a custom board. The FPC interface used for this module is not generic, and in order to connect it to the RW BGA board we already need a breakout PCB (which I believe itself was a custom one-off board)

Essentially, while we should support this display upstream I think there is limited use in adding it as a generic shield, because interfacing with it essentially requires a custom board.

@decsny
Copy link
Member

decsny commented May 21, 2024

can this display also work with the frdm_rw612 board?

In theory it can work with any board that has a SPI interface. The reason I defined this display module for the RW board specifically is because I think it has limited use outside of a custom board. The FPC interface used for this module is not generic, and in order to connect it to the RW BGA board we already need a breakout PCB (which I believe itself was a custom one-off board)

Essentially, while we should support this display upstream I think there is limited use in adding it as a generic shield, because interfacing with it essentially requires a custom board.

don't think this is the right mindset, imo all boards are custom, including vendor EVKs, they shouldn't be special cases

@danieldegrasse
Copy link
Collaborator Author

danieldegrasse commented May 21, 2024

don't think this is the right mindset, imo all boards are custom, including vendor EVKs, they shouldn't be special cases

This is fair- I'm open to changing this into a shield, but what exactly do we call the gpio nexus node for it? goworld_16880_display_fpc?

To be clear, the reason that I did not define this as a shield is that (IMO) a module warrants being defined as a shield once multiple in tree boards feature a connector that interfaces with the shield. So far zero boards in tree feature a connector for this display module (I connect it to the RW612 BGA using flying wires). I truthfully don't see this module being used much as a shield (given that I have been unable to find the datasheet online, let alone an order link). That being said if we'd like to define this as a shield, I'll convert this PR do to so

@nashif nashif merged commit 0707a6f into zephyrproject-rtos:main May 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants