isOriginAllowed method in cors package might need to remove the prefix dot char.
#3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwan
changed the title
isOriginAllowed method in cors package might need to remove the prefix dot char.
kevwan
force-pushed
the
fix_cors_origin_allow
branch
from
3ed5cbf
to
ad99079
Compare
kevwan
added
area/restful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cors 包的 isOriginAllowed 方法在1.5版本之后校验的时候拼接了【.】前缀，的确避免了域名包含的问题，但是将完整的域名（不包含http头部的）的也给误杀了，造成升级之后的配置文件失效；感觉若是想决绝域名屏蔽的问题自己的配置文件添加【.】前缀更加友好