Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-4024: support array field for request dto #4052

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feature-4024: support array field for request dto #4052

wants to merge 1 commit into from

Conversation

shyandsy
Copy link
Contributor

@shyandsy shyandsy commented Apr 9, 2024

fixed the array parsing issue, and made more test case for this

solution

  1. GetFormValues always return array even if there is single value for keys
  2. in the unmarshall process, if we found the correspond field is not array, then we just pick up the first element of the slice

@shyandsy shyandsy mentioned this pull request Apr 9, 2024
Closed
@shyandsy shyandsy marked this pull request as draft April 9, 2024 02:03
@kevwan
Copy link
Contributor

kevwan commented Apr 9, 2024

Don't fix it like this. It breaks the type matching check.

@kevwan kevwan added the do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because of known issues or need more discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shyandsy @kevwan